Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 01:51
@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/kebabCaseEventName

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.5 kB
vue.global.prod.js 166 kB 60.5 kB 53.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB 18.9 kB 17.3 kB
createApp 57.2 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.3 kB 35.6 kB 32 kB
createVaporApp 42.3 kB 15.6 kB 14.2 kB
createSSRApp 61.6 kB 23.8 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 71.9 kB 27.2 kB 24.8 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14211
npm i https://pkg.pr.new/@vue/compiler-core@14211
yarn add https://pkg.pr.new/@vue/compiler-core@14211.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14211
npm i https://pkg.pr.new/@vue/compiler-dom@14211
yarn add https://pkg.pr.new/@vue/compiler-dom@14211.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14211
npm i https://pkg.pr.new/@vue/compiler-sfc@14211
yarn add https://pkg.pr.new/@vue/compiler-sfc@14211.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14211
npm i https://pkg.pr.new/@vue/compiler-ssr@14211
yarn add https://pkg.pr.new/@vue/compiler-ssr@14211.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14211
npm i https://pkg.pr.new/@vue/compiler-vapor@14211
yarn add https://pkg.pr.new/@vue/compiler-vapor@14211.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14211
npm i https://pkg.pr.new/@vue/reactivity@14211
yarn add https://pkg.pr.new/@vue/reactivity@14211.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14211
npm i https://pkg.pr.new/@vue/runtime-core@14211
yarn add https://pkg.pr.new/@vue/runtime-core@14211.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14211
npm i https://pkg.pr.new/@vue/runtime-dom@14211
yarn add https://pkg.pr.new/@vue/runtime-dom@14211.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14211
npm i https://pkg.pr.new/@vue/runtime-vapor@14211
yarn add https://pkg.pr.new/@vue/runtime-vapor@14211.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14211
npm i https://pkg.pr.new/@vue/server-renderer@14211
yarn add https://pkg.pr.new/@vue/server-renderer@14211.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14211
npm i https://pkg.pr.new/@vue/shared@14211
yarn add https://pkg.pr.new/@vue/shared@14211.tgz

vue

pnpm add https://pkg.pr.new/vue@14211
npm i https://pkg.pr.new/vue@14211
yarn add https://pkg.pr.new/vue@14211.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14211
npm i https://pkg.pr.new/@vue/compat@14211
yarn add https://pkg.pr.new/@vue/compat@14211.tgz

commit: 235705d

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Vapor compiler to properly camelize kebab-case component event handlers, aligning its behavior with the standard Vue compiler. Previously, kebab-case event names like @update-model were incorrectly kept as "onUpdate-model" instead of being converted to onUpdateModel.

Key Changes:

  • Apply camelize transformation to static event handler keys before converting them to handler format
  • Update existing test expectations to reflect the corrected behavior
  • Add new test case specifically for kebab-case event handler camelization

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/compiler-vapor/src/generators/prop.ts Imports camelize and applies it to static handler keys before toHandlerKey conversion
packages/compiler-vapor/tests/transforms/vOn.spec.ts Updates test expectation for @update-model to generate camelized onUpdateModel and adds new test for kebab-case camelization
packages/compiler-vapor/tests/transforms/snapshots/vOn.spec.ts.snap Updates snapshots to reflect corrected camelized output for kebab-case handlers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 merged commit b205408 into minor Dec 17, 2025
23 checks passed
@edison1105 edison1105 deleted the edison/fix/kebabCaseEventName branch December 17, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants