perf(runtime-vapor): tree-shake slot fallback from non-slot bundles#14765
perf(runtime-vapor): tree-shake slot fallback from non-slot bundles#14765edison1105 merged 5 commits intominorfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
72029d3 to
6c3129d
Compare
6c3129d to
35ab981
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/runtime-vapor/src/transition.ts`:
- Around line 16-17: applyTransitionHooks and applyTransitionLeaveHooks are
exported but left undefined causing runtime throws when called (e.g.,
fragment.ts invokes applyTransitionLeaveHooks). Initialize both registries to
safe no-op defaults: replace the undefined exports with functions named
applyTransitionHooks and applyTransitionLeaveHooks that match their declared
types (ApplyTransitionHooksFn, ApplyTransitionLeaveHooksFn) and perform a safe
no-op (sync or returning Promise/void as required by the types) so callers in
fragment.ts and elsewhere can call them before any registration occurs without
crashing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 86cefcc6-af3f-4324-946e-a27ad35a5f12
📒 Files selected for processing (19)
packages/runtime-vapor/src/apiCreateDynamicComponent.tspackages/runtime-vapor/src/apiCreateFor.tspackages/runtime-vapor/src/apiDefineAsyncComponent.tspackages/runtime-vapor/src/apiTemplateRef.tspackages/runtime-vapor/src/block.tspackages/runtime-vapor/src/component.tspackages/runtime-vapor/src/components/KeepAlive.tspackages/runtime-vapor/src/components/Suspense.tspackages/runtime-vapor/src/components/Teleport.tspackages/runtime-vapor/src/fragment.tspackages/runtime-vapor/src/helpers/setKey.tspackages/runtime-vapor/src/helpers/useCssVars.tspackages/runtime-vapor/src/hmr.tspackages/runtime-vapor/src/index.tspackages/runtime-vapor/src/keepAlive.tspackages/runtime-vapor/src/suspense.tspackages/runtime-vapor/src/teleport.tspackages/runtime-vapor/src/transition.tspackages/runtime-vapor/src/vdomInterop.ts
Summary by CodeRabbit