Skip to content

fix(runtime-vapor): preserve teleport child scope for directive cleanup#14776

Merged
edison1105 merged 1 commit intominorfrom
edison/fix/14773
May 5, 2026
Merged

fix(runtime-vapor): preserve teleport child scope for directive cleanup#14776
edison1105 merged 1 commit intominorfrom
edison/fix/14773

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented May 4, 2026

close #14773

Summary by CodeRabbit

  • Bug Fixes

    • Fixed directive cleanup for teleported elements when unmounting. Directives attached to teleported components now properly execute their teardown functions when the teleport branch is removed.
  • Tests

    • Added test coverage for directive cleanup behavior in teleport scenarios.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0570f93c-1407-4df6-9443-3662dd515d2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edison/fix/14773

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 4, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14776
npm i https://pkg.pr.new/@vue/compiler-core@14776
yarn add https://pkg.pr.new/@vue/compiler-core@14776.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14776
npm i https://pkg.pr.new/@vue/compiler-dom@14776
yarn add https://pkg.pr.new/@vue/compiler-dom@14776.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14776
npm i https://pkg.pr.new/@vue/compiler-sfc@14776
yarn add https://pkg.pr.new/@vue/compiler-sfc@14776.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14776
npm i https://pkg.pr.new/@vue/compiler-ssr@14776
yarn add https://pkg.pr.new/@vue/compiler-ssr@14776.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14776
npm i https://pkg.pr.new/@vue/compiler-vapor@14776
yarn add https://pkg.pr.new/@vue/compiler-vapor@14776.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14776
npm i https://pkg.pr.new/@vue/reactivity@14776
yarn add https://pkg.pr.new/@vue/reactivity@14776.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14776
npm i https://pkg.pr.new/@vue/runtime-core@14776
yarn add https://pkg.pr.new/@vue/runtime-core@14776.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14776
npm i https://pkg.pr.new/@vue/runtime-dom@14776
yarn add https://pkg.pr.new/@vue/runtime-dom@14776.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14776
npm i https://pkg.pr.new/@vue/runtime-vapor@14776
yarn add https://pkg.pr.new/@vue/runtime-vapor@14776.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14776
npm i https://pkg.pr.new/@vue/server-renderer@14776
yarn add https://pkg.pr.new/@vue/server-renderer@14776.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14776
npm i https://pkg.pr.new/@vue/shared@14776
yarn add https://pkg.pr.new/@vue/shared@14776.tgz

vue

pnpm add https://pkg.pr.new/vue@14776
npm i https://pkg.pr.new/vue@14776
yarn add https://pkg.pr.new/vue@14776.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14776
npm i https://pkg.pr.new/@vue/compat@14776
yarn add https://pkg.pr.new/@vue/compat@14776.tgz

commit: 16eb30f

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.3 kB 26.6 kB
runtime-dom.global.prod.js 113 kB 42.4 kB 38 kB
vue.global.prod.js 172 kB 62.2 kB 55.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 51.3 kB 20 kB 18.3 kB
createApp 60.4 kB 23.3 kB 21.2 kB
createApp + vaporInteropPlugin 101 kB (+4 B) 36.2 kB (+11 B) 32.8 kB (+12 B)
createVaporApp 27.4 kB (+4 B) 10.7 kB (-4 B) 9.77 kB (+3 B)
createSSRApp 64.9 kB 25.1 kB 22.8 kB
createVaporSSRApp 32.9 kB (+4 B) 12.6 kB (-1 B) 11.6 kB (+2 B)
defineCustomElement 67 kB 25.3 kB 23 kB
defineVaporCustomElement 40.1 kB (+4 B) 14.3 kB (-3 B) 13.1 kB (-6 B)
overall 75.4 kB 28.7 kB 26.1 kB

@edison1105 edison1105 added scope: teleport scope: vapor related to vapor mode labels May 4, 2026
@edison1105 edison1105 merged commit ab19c52 into minor May 5, 2026
16 of 17 checks passed
@edison1105 edison1105 deleted the edison/fix/14773 branch May 5, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: teleport scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant