Skip to content

fix(runtime-vapor): avoid retaining vdom interop from emits#14798

Merged
edison1105 merged 5 commits intominorfrom
edison/refactor/tweaks
May 11, 2026
Merged

fix(runtime-vapor): avoid retaining vdom interop from emits#14798
edison1105 merged 5 commits intominorfrom
edison/refactor/tweaks

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented May 11, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling during component rendering and updates to ensure internal state is properly restored even when exceptions occur.
    • Fixed prop application and component initialization state cleanup when errors are thrown.
  • Tests

    • Added test coverage for error handling scenarios in render effects, prop application, and component creation to verify proper state restoration.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9dd359d2-7b30-45a4-87d9-750091449cd1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edison/refactor/tweaks

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 11, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14798
npm i https://pkg.pr.new/@vue/compiler-core@14798
yarn add https://pkg.pr.new/@vue/compiler-core@14798.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14798
npm i https://pkg.pr.new/@vue/compiler-dom@14798
yarn add https://pkg.pr.new/@vue/compiler-dom@14798.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14798
npm i https://pkg.pr.new/@vue/compiler-sfc@14798
yarn add https://pkg.pr.new/@vue/compiler-sfc@14798.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14798
npm i https://pkg.pr.new/@vue/compiler-ssr@14798
yarn add https://pkg.pr.new/@vue/compiler-ssr@14798.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14798
npm i https://pkg.pr.new/@vue/compiler-vapor@14798
yarn add https://pkg.pr.new/@vue/compiler-vapor@14798.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14798
npm i https://pkg.pr.new/@vue/reactivity@14798
yarn add https://pkg.pr.new/@vue/reactivity@14798.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14798
npm i https://pkg.pr.new/@vue/runtime-core@14798
yarn add https://pkg.pr.new/@vue/runtime-core@14798.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14798
npm i https://pkg.pr.new/@vue/runtime-dom@14798
yarn add https://pkg.pr.new/@vue/runtime-dom@14798.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14798
npm i https://pkg.pr.new/@vue/runtime-vapor@14798
yarn add https://pkg.pr.new/@vue/runtime-vapor@14798.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14798
npm i https://pkg.pr.new/@vue/server-renderer@14798
yarn add https://pkg.pr.new/@vue/server-renderer@14798.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14798
npm i https://pkg.pr.new/@vue/shared@14798
yarn add https://pkg.pr.new/@vue/shared@14798.tgz

vue

pnpm add https://pkg.pr.new/vue@14798
npm i https://pkg.pr.new/vue@14798
yarn add https://pkg.pr.new/vue@14798.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14798
npm i https://pkg.pr.new/@vue/compat@14798
yarn add https://pkg.pr.new/@vue/compat@14798.tgz

commit: b5fab2e

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.5 kB 30.3 kB 26.6 kB
runtime-dom.global.prod.js 113 kB 42.6 kB 38.1 kB
vue.global.prod.js 172 kB 62.4 kB 55.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 51.5 kB 20.1 kB 18.3 kB
createApp 60.5 kB 23.4 kB 21.3 kB
createApp + vaporInteropPlugin 103 kB (+91 B) 37.1 kB (+63 B) 33.4 kB (-20 B)
createVaporApp 27.5 kB (+48 B) 10.7 kB (+8 B) 9.78 kB (+9 B)
createSSRApp 65 kB 25.2 kB 22.9 kB
createVaporSSRApp 33.7 kB (+48 B) 12.8 kB (+9 B) 11.8 kB (-2 B)
defineCustomElement 67.1 kB 25.4 kB 23.1 kB
defineVaporCustomElement 40.2 kB (+54 B) 14.3 kB (+7 B) 13.1 kB (+2 B)
overall 75.8 kB 28.9 kB 26.2 kB

@edison1105 edison1105 added the scope: vapor related to vapor mode label May 11, 2026
@edison1105 edison1105 merged commit 3212075 into minor May 11, 2026
17 checks passed
@edison1105 edison1105 deleted the edison/refactor/tweaks branch May 11, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant