Skip to content

perf(runtime-vapor): only create lifecycle update jobs when needed#14824

Merged
edison1105 merged 1 commit into
minorfrom
edison/perf/renderEffect
May 15, 2026
Merged

perf(runtime-vapor): only create lifecycle update jobs when needed#14824
edison1105 merged 1 commit into
minorfrom
edison/perf/renderEffect

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented May 15, 2026

Summary by CodeRabbit

  • Tests

    • Added comprehensive test coverage for effect lifecycle management, including lazy job creation and update hook registration scenarios.
  • Chores

    • Refactored effect initialization to support configurable lifecycle behavior and defer resource allocation until needed, improving performance.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 89900092-8589-4afc-8c65-ae08d83563b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edison/perf/renderEffect

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.5 kB 30.3 kB 26.6 kB
runtime-dom.global.prod.js 113 kB 42.6 kB 38.1 kB
vue.global.prod.js 172 kB 62.4 kB 55.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 51.5 kB 20.1 kB 18.3 kB
createApp 60.5 kB 23.4 kB 21.3 kB
createApp + vaporInteropPlugin 103 kB (+9 B) 37.3 kB (-2 B) 33.7 kB (+2 B)
createVaporApp 27.6 kB (+9 B) 10.7 kB 9.84 kB (-3 B)
createSSRApp 65 kB 25.2 kB 22.9 kB
createVaporSSRApp 33.8 kB (+9 B) 12.9 kB (-5 B) 11.9 kB (-1 B)
defineCustomElement 67.1 kB 25.4 kB 23.2 kB
defineVaporCustomElement 39.8 kB (+9 B) 14.3 kB (+4 B) 13.1 kB (+6 B)
overall 75.8 kB 28.9 kB 26.2 kB

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 15, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14824
npm i https://pkg.pr.new/@vue/compiler-core@14824
yarn add https://pkg.pr.new/@vue/compiler-core@14824.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14824
npm i https://pkg.pr.new/@vue/compiler-dom@14824
yarn add https://pkg.pr.new/@vue/compiler-dom@14824.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14824
npm i https://pkg.pr.new/@vue/compiler-sfc@14824
yarn add https://pkg.pr.new/@vue/compiler-sfc@14824.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14824
npm i https://pkg.pr.new/@vue/compiler-ssr@14824
yarn add https://pkg.pr.new/@vue/compiler-ssr@14824.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14824
npm i https://pkg.pr.new/@vue/compiler-vapor@14824
yarn add https://pkg.pr.new/@vue/compiler-vapor@14824.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14824
npm i https://pkg.pr.new/@vue/reactivity@14824
yarn add https://pkg.pr.new/@vue/reactivity@14824.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14824
npm i https://pkg.pr.new/@vue/runtime-core@14824
yarn add https://pkg.pr.new/@vue/runtime-core@14824.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14824
npm i https://pkg.pr.new/@vue/runtime-dom@14824
yarn add https://pkg.pr.new/@vue/runtime-dom@14824.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14824
npm i https://pkg.pr.new/@vue/runtime-vapor@14824
yarn add https://pkg.pr.new/@vue/runtime-vapor@14824.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14824
npm i https://pkg.pr.new/@vue/server-renderer@14824
yarn add https://pkg.pr.new/@vue/server-renderer@14824.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14824
npm i https://pkg.pr.new/@vue/shared@14824
yarn add https://pkg.pr.new/@vue/shared@14824.tgz

vue

pnpm add https://pkg.pr.new/vue@14824
npm i https://pkg.pr.new/vue@14824
yarn add https://pkg.pr.new/vue@14824.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14824
npm i https://pkg.pr.new/@vue/compat@14824
yarn add https://pkg.pr.new/@vue/compat@14824.tgz

commit: c2bfa71

@edison1105 edison1105 added the scope: vapor related to vapor mode label May 15, 2026
@edison1105 edison1105 merged commit 0efdb81 into minor May 15, 2026
16 of 17 checks passed
@edison1105 edison1105 deleted the edison/perf/renderEffect branch May 15, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant