Skip to content

Conversation

@Bigfish8
Copy link
Contributor

@Bigfish8 Bigfish8 commented Aug 13, 2021

Close #4310
I think it is unnecessary to support this condition.But add compiler error will be helpful.

@yyx990803
Copy link
Member

yyx990803 commented Aug 16, 2021

I don't even think this needs to be specifically about usage of scope variables. v-once isn't designed to be used inside v-for so the check and the warning message can both be simpler.

@Bigfish8
Copy link
Contributor Author

I don't even think this needs to be specifically about usage of scope variables. v-once isn't designed to be used inside v-for so the check and the warning message can both be simpler.

Thanks for the review, I will simplify it.

@yyx990803
Copy link
Member

Could you also add the same check for v-memo since they have the same limitations?

@Bigfish8
Copy link
Contributor Author

Yes, I’ll be glad to.

zhangyu96 added 2 commits August 18, 2021 11:31
@Bigfish8
Copy link
Contributor Author

I changed the indentation of the previous test because of the separation between describe('transform') with describe('errors').So it seems there are many changes.

@edison1105 edison1105 added scope: compiler 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. wait changes labels Oct 29, 2024
@edison1105
Copy link
Member

Could you please resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: compiler wait changes

Projects

Development

Successfully merging this pull request may close these issues.

v-once inside v-for

3 participants