fix (server-renderer): stability - stop server crashing with unhandled promise rejection #7660
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jection. If an async component throws an error whilst another async component is being rendered it results in a unhandled promise rejection and the server crashing.
peteclark82
changed the title
edison1105
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an async component throws a template rendering error whilst another async component is being rendered it results in a unhandled promise rejection and the server crashing. This is because the async components are processed in a synchronous loop (via unrollBuffer) creating this race condition.
Much like if there are prefetches, we must explicitly add error handling to the promise. We are still returning the original promise so that the error handling hooks can still process the error correctly.