fix(overlay): use toggleEnabled instead of enable to allow exiting in…#1067
Open
SaKaNa-Y wants to merge 4 commits intovuejs:mainfrom
Open
fix(overlay): use toggleEnabled instead of enable to allow exiting in…#1067SaKaNa-Y wants to merge 4 commits intovuejs:mainfrom
SaKaNa-Y wants to merge 4 commits intovuejs:mainfrom
Conversation
…spector mode When using it, I noticed that Escape is the only way to exit. Clicking the button again doesn’t toggle the state, so I think adding a toggle feature would improve the user experience.
✅ Deploy Preview for vue-devtools-docs canceled.
|
skirtles-code
suggested changes
Mar 20, 2026
Contributor
skirtles-code
left a comment
skirtles-code
left a comment
There was a problem hiding this comment.
A similar change was attempted in #893, but it contained a bug (if(vueInspectorEnabled.value) was not the correct check) and was reverted just after being merged.
I think this change is a good idea. Toggling seems much more natural to me. Even the tooltip for that button reads Toggle Component Inspector.
tip: I think the inspector button should be highlighted when element selection is active and not highlighted when selection is canceled.This way, the user perception will be much clearer.
Agreed. I've attempted that in #1069.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…spector mode
When using it, I noticed that Escape is the only way to exit. Clicking the button again doesn’t toggle the state, so I think adding a toggle feature would improve the user experience.
tip: I think the inspector button should be highlighted when element selection is active and not highlighted when selection is canceled.This way, the user perception will be much clearer.