fix(devtools-kit): remove special handling for Router object#1092
Merged
webfansplz merged 1 commit intovuejs:mainfrom Apr 26, 2026
Merged
fix(devtools-kit): remove special handling for Router object#1092webfansplz merged 1 commit intovuejs:mainfrom
webfansplz merged 1 commit intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
@vue/devtools-electron
@vue/devtools-shared
@vue/devtools-ui
vite-plugin-vue-devtools
commit: |
webfansplz
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently some special handling for rendering a Vue Router instance. However...
val.constructor.name === 'VueRouter'is for the Vue 2 router, so it doesn't do anything with Vue 3. The code involvinggetRouterDetailsdoesn't actually run.replacer.tsreturns'[object Router]', which isn't very helpful (see Before screenshot below).I had originally intended to fix that second code path to call
getRouterDetails, which did work, but it then occurred to me that none of this is really necessary. Maybe at some point in the past there were issues displaying the router instance, but just treating it like any other object works fine now.Before:
After: