Skip to content

Conversation

@lucaspagliari
Copy link

Description of Problem

Allow users to quickly toggle between APIs
Enhancement on user experience when reading docs.
Relates to this issue #1409

Proposed Solution

Add an event listener on window when mounting component. Implemented a handler to verify if ctrl + space or ⌘ + space were pressed. And then run toggleCompositionAPI()

Additional Information

Needs improvement to show users that this hotKey is available, but I'm open to help with that

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for vuejs ready!

🔨 Explore the source changes: 67e4b1c

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/620c8cabe9bd42000832fa1a

😎 Browse the preview: https://deploy-preview-1551--vuejs.netlify.app

@lucaspagliari lucaspagliari force-pushed the toggle-composition-hotkey branch from 3626e1f to 67e4b1c Compare February 16, 2022 05:33
@lucaspagliari lucaspagliari changed the title Add HotKey "Ctrl + Space" for switching between Options and Compostion API Add HotKey "Ctrl + Space" for switching between Options and Compostion API (issue: #1409) Feb 19, 2022
@skirtles-code
Copy link
Contributor

@lucaspagliari I'm sorry that you didn't get a response until now. The work you did on this should have been acknowledged a long time ago. I thought someone had already responded, but that was just the netlify bot.

We have two PRs implementing #1409, the other being #1449. For various reasons that other PR hasn't been merged yet, but it is at a more advanced stage than this PR and I think we'll be merging that one relatively soon. Had that PR not already existed, I see no reason why we wouldn't have proceeded with merging this PR instead.

Sorry again for the delay and thank you for the work you put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants