fix(no-v-html): add CallExpression support to ignorePattern option #2950
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b9ebc7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…uejs#2949) This commit extends the `ignorePattern` option to support function call expressions like `$sanitize(test)`, not just simple variable identifiers like `htmlSafe`. Changes: - Add new `shouldIgnore()` helper function that handles both Identifier and CallExpression expression types - For Identifiers, use the `name` property directly for optimal performance - For CallExpressions and other expression types, use `sourceCode.getText()` to get the full expression text - Update the visitor to pass `sourceCode` to the new helper function This allows users to configure patterns like `^\$sanitize\(` to match function call expressions where the function name matches the pattern. Tests: - Add test case for CallExpression matching with ignorePattern `^\$sanitize\(` - All existing tests continue to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2949
Extends the
ignorePatternoption to support CallExpression (function call)patterns like
$sanitize(test), previously only supporting simple identifiers.This allows users to ignore sanitized HTML expressions using patterns such as
^\$sanitize\(.