-
-
Notifications
You must be signed in to change notification settings - Fork 700
test: remove type in errors
#2966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
FYI: Lint errors fixed in #2981, so I updated your branch with that. |
|
Just a heads-up: there are other test cases in the repository aren’t verifying the location info. |
FloEdelmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙂
Just a heads-up: there are other test cases in the repository aren’t verifying the location info.
Yeah, I know. I just didn't want to make the tests weaker by removing type and not adding location. Ideally we'd add the location everywhere but that's clearly out of scope for this PR 😅
Related:
LintMessage#nodeTypeandTestCaseError#typeeslint/eslint#19029