Skip to content

Conversation

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

⚠️ No Changeset found

Latest commit: 49352c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@FloEdelmann
Copy link
Member

FYI: Lint errors fixed in #2981, so I updated your branch with that.

@9romise 9romise requested a review from FloEdelmann November 27, 2025 11:39
@9romise
Copy link
Contributor Author

9romise commented Nov 27, 2025

Just a heads-up: there are other test cases in the repository aren’t verifying the location info.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

Just a heads-up: there are other test cases in the repository aren’t verifying the location info.

Yeah, I know. I just didn't want to make the tests weaker by removing type and not adding location. Ideally we'd add the location everywhere but that's clearly out of scope for this PR 😅

@FloEdelmann FloEdelmann merged commit 7523350 into vuejs:master Nov 27, 2025
15 checks passed
@9romise 9romise deleted the cleanup-test branch November 27, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants