Skip to content

Conversation

@vuejs-jp-bot
Copy link
Collaborator

Cherry picked from vuejs/v2.vuejs.org@6cdc99b

* Recommend return type annotation

* make explanation clear, thank @DanielRosenwasser
@potato4d potato4d self-requested a review October 28, 2017 16:20
Copy link
Collaborator

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これに関しては普通に翻訳が必要そうですね(Slack側で担当が明確化されていますしこれ自体はCloseしても良さそうかと思います)

@kazupon
Copy link
Member

kazupon commented Oct 29, 2017

@re-fort 閉じましょうか?
それともこのPRにadditional commitsします?

@re-fort
Copy link
Collaborator

re-fort commented Oct 29, 2017

@kazupon @potato4d
今回はこちらでadditional commitsしますー!

@re-fort
Copy link
Collaborator

re-fort commented Oct 29, 2017

@kazupon @potato4d
対応しました〜

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kazupon kazupon merged commit a9bb24d into vuejs:lang-ja Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants