-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: resilient _VUE_DEVTOOLS_TOAST_ #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is weird since the devtools should be installed at that point. I would need to have more details to ensure this is the right fix |
|
I found out that it is caused by the devtools failing to load a specific source (vuejs/devtools-v6#1322 (comment)) However, I think that adding this extra sanity check is reasonable since relying on globally available methods like this is always at the risk of failure, causing console spam |
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)Other information:
When using Pinia v2 with the latest beta of Vue devtools, I always experience the following console error:
While I cannot exactly pin down the exact cause of this, I think its reasonable to fall back to console output whenever the devtools's toast is not available