Skip to content

fix: resilient _VUE_DEVTOOLS_TOAST_ #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2021
Merged

fix: resilient _VUE_DEVTOOLS_TOAST_ #334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
275b2c9
fix: Error when _VUE_DEVTOOLS_TOAST_ is undefined
timozander Jan 15, 2021
f806680
style: implement review changes
timozander Jan 17, 2021
a3d5a8d
Apply suggestions from code review
posva Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/devtools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,23 @@ function formatDisplay(display: string) {
}
}

function toastMessage(
message: string,
type?: 'normal' | 'error' | 'warning' | undefined
) {
const piniaMessage = '🍍 ' + message

if (typeof __VUE_DEVTOOLS_TOAST__ === 'function') {
__VUE_DEVTOOLS_TOAST__(piniaMessage, type)
} else if (type === 'error') {
console.error(piniaMessage)
} else if (type === 'warning') {
console.warn(piniaMessage)
} else {
console.log(piniaMessage)
}
}

let isAlreadyInstalled: boolean | undefined

export function addDevtools(app: App, store: GenericStore) {
Expand Down Expand Up @@ -116,18 +133,15 @@ export function addDevtools(app: App, store: GenericStore) {
options: formatStoreForInspectorState(store),
}
} else {
__VUE_DEVTOOLS_TOAST__(
`🍍 store "${payload.nodeId}" not found`,
'error'
)
toastMessage(`store "${payload.nodeId}" not found`, 'error')
}
}
})

// trigger an update so it can display new registered stores
// @ts-ignore
api.notifyComponentUpdate()
__VUE_DEVTOOLS_TOAST__(`🍍 "${store.$id}" store installed`)
toastMessage(`"${store.$id}" store installed`)
}
)
}
Expand Down