Add global configuration settings #53
Conversation
|
Hm, is this the same as |
|
Theoretically it is, the PR is just to have feature parity with the Vue config API. |
|
let's make this global. This is esp. useful for mocking |
There was a problem hiding this comment.
Just one comment about allowing passing globalProperties to as a mounting option - not sure if it makes sense (not something we support in beta iirc). If something is global, it should be applied on all components - what's the use case to override it locally?
looking good, lodash makes things so easy 🎉
dobromir-hristov
changed the title
dobromir-hristov
force-pushed
the
feat/add-global-properties
branch
from
d37a814 to
2ec6d17
Compare
# Conflicts: # src/types.ts
| configGlobal = {}, | ||
| mountGlobal = {} | ||
| ): GlobalMountOptions { | ||
| return mergeWith({}, configGlobal, mountGlobal, (objValue, srcValue, key) => { |
| import { GlobalMountOptions } from './types' | ||
|
|
||
| export const config: { global: GlobalMountOptions } = { | ||
| global: {} |
There was a problem hiding this comment.
Should I add each of the properties here, with an empty array or object?
| return { ...objValue, ...srcValue } | ||
| case 'plugins': | ||
| case 'mixins': | ||
| return [...(objValue || []), ...(srcValue || [])].filter(Boolean) |
There was a problem hiding this comment.
This will not overwrite a plugin or mixin if defined globally first, it will concat them. That should be fine though?
# Conflicts: # src/mount.ts
3 participants
This PR adds a global config object, to allow users to add global Mixins, mocks or others for all Test files.
Closes #35