Skip to content

Use correct event hook name #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2019
Merged

Use correct event hook name #2218

merged 1 commit into from
Jul 6, 2019

Conversation

@pine
Copy link
Contributor

@pine pine commented Jul 2, 2019

Hi. I think beforeRouteEnter is new hook name, so it is not detectted by migration helper.
activate is old hook name.

Thank you.

@pine pine changed the title Use correct method name Use correct event hook name Jul 2, 2019
NataliaTepluhina
NataliaTepluhina approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 👍

@NataliaTepluhina NataliaTepluhina merged commit bd7cc71 into vuejs:master Jul 6, 2019
@vue-bot
Copy link
Contributor

vue-bot commented Jul 6, 2019

Hey @pine, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@pine pine deleted the patch-1 branch July 9, 2019 09:35
@pine pine mentioned this pull request Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pine @vue-bot @NataliaTepluhina