Skip to content

Adds support for scoped selectors in @supports queries #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyx990803 merged 3 commits into from
Jul 29, 2017
Merged

Adds support for scoped selectors in @supports queries #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff2f80e
Adds support for scoped selectors in @supports queries
Jul 25, 2017
0c13672
Update test.js
fimion Jul 25, 2017
d7153a2
Update scope-id.js
yyx990803 Jul 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/style-compiler/plugins/scope-id.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = postcss.plugin('add-id', function (opts) {
if (!node.selector) {
// handle media queries
if (node.type === 'atrule') {
if (node.name === 'media') {
if (node.name === 'media' || node.name === 'supports') {
node.each(rewriteSelector)
} else if (node.name === 'keyframes') {
// register keyframes
Expand Down
7 changes: 7 additions & 0 deletions test/fixtures/supports-query.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<style scoped>
@supports ( color: #000 ) {
.foo {
color: #000;
}
}
</style>
12 changes: 12 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,18 @@ describe('vue-loader', function () {
})
})

it('supports-query', done => {
test({
entry: './test/fixtures/supports-query.vue'
}, (window) => {
var style = window.document.querySelector('style').textContent
style = normalizeNewline(style)
var id = 'data-v-' + hash('vue-loader/test/fixtures/supports-query.vue')
expect(style).to.contain('@supports ( color: #000 ) {\n.foo[' + id + '] {\n color: #000;\n}\n}')
done()
})
})

it('extract CSS', done => {
bundle({
entry: './test/fixtures/extract-css.vue',
Expand Down