fix: wait for the next tick #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to https://vue-test-utils.vuejs.org/guides/#using-nexttick we have to wait for the next tick for this test to pass
JessicaSachs
reviewed
Jan 3, 2020
| And create a test file named `test/Counter.spec.js` with the following code: | ||
|
|
||
| ```js | ||
| import Vue from 'vue'; |
Collaborator
There was a problem hiding this comment.
Thank you for the PR! Prettier is complaining about this semicolon. yarn run format will fix it.
Contributor
There was a problem hiding this comment.
You can also use wrapper.vm.$nextTick(), but this could be a bit more future proof, as nextTick will no longer be avail on the vm in V3...
JessicaSachs
requested changes
Jan 3, 2020
Collaborator
JessicaSachs
left a comment
JessicaSachs
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing this! There is a small formatting change needed before merging. You can exec prettier via yarn run format.
We might run the linter as a githook to avoid this problem in the future.
Contributor
|
I can add prettier to run auto on my commit lint branch. |
lmiller1990
reviewed
Jan 3, 2020
Member
lmiller1990
left a comment
lmiller1990
left a comment
There was a problem hiding this comment.
LGTM once prettier is run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to https://vue-test-utils.vuejs.org/guides/#using-nexttick we have to wait for the next tick for this test to pass