This repository was archived by the owner on Dec 26, 2018. It is now read-only.
add $event property to vm #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Needed access to $event in a custom event. Works great. |
|
why would you need that if you pass the event as an argument anyway? |
franky47
reviewed
Sep 21, 2016
| // define new handler | ||
| this.handler = function (e) { | ||
| e.targetVM = vm | ||
| vm.$event = e |
There was a problem hiding this comment.
Wouldn't it be interesting to store the previous value of vm.$event (if any), and restore it afterwards ? This could avoid some issues with other pieces of code that might use $event.
|
Hey, thanks for the PR but since the 1.0 version is not really maintained anymore in terms of adding new features, I will close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.