This repository was archived by the owner on Dec 26, 2018. It is now read-only.
remove unnecessary condition which blocks gc #54
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code above has removed the event handler, so the condition is not necessary.
The
off()hammerjs provide has a bug that it does not remove the event key onhandlersobject unless calling it without the second argument, so there will be a blank array left if you remove the last handler by calling theoff()with a second argument.In this context, the
handlerswill contains atapkey with a value of[], you should cover it if the condition is really necessary.