Skip to content
This repository was archived by the owner on Dec 26, 2018. It is now read-only.

Conversation

@viclm
Copy link

@viclm viclm commented Nov 3, 2016

The code above has removed the event handler, so the condition is not necessary.

The off() hammerjs provide has a bug that it does not remove the event key on handlers object unless calling it without the second argument, so there will be a blank array left if you remove the last handler by calling the off() with a second argument.

In this context, the handlers will contains a tap key with a value of [], you should cover it if the condition is really necessary.

@viclm viclm closed this Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant