Update $refs type declaration
#3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
Sep 26, 2016
Member
ktsn
left a comment
ktsn
left a comment
There was a problem hiding this comment.
According to doc, $refs also can be Array.
So $refs should be Vue | Element | Vue[] | Element[]?
When used on elements/components with v-for, the registered reference will be an Array containing DOM nodes or component instances.
Member
Author
|
CI breaks... Any idea on it? |
Member
Author
|
|
Member
|
Yeah, it happens recently... Don't mind about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc,
$refsis a dictionary ofVueinstance orElement. This pull request reflect this by a union type. So users can declare html elements in$refs.A test is also added. User defined components may have better knowledge about
$refs' data structure. So users can also reify special properties to more specific types.@ktsn your review is appreciated, thanks.