Skip to content

Conversation

@sarahdayan
Copy link
Contributor

This adds the new logo by @geneparcellano to the repository and documentation.

Before

Capture d’écran 2020-02-06 à 17 50 38

After

Capture d’écran 2020-02-06 à 17 50 55

fix #158

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.73%. Comparing base (2ce789c) to head (e13a3cd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          14       14           
  Lines         377      377           
  Branches       69       69           
=======================================
  Hits          376      376           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@posva
Copy link
Member

posva commented Feb 6, 2020

Thank you!! Can we make wider and smaller in height though? It doesn't have to be squared, but similar proportions to the Firebase logo would be better

@sarahdayan
Copy link
Contributor Author

@posva If we make it wider it will increase the height as well, unless we alter the illustration itself. I could do it but I think it's a better idea for @geneparcellano to take care of it 🙂

@posva
Copy link
Member

posva commented Feb 6, 2020

I see. Yes, I want the illustration to be altered, it's too vertical right now

@geneparcellano
Copy link

I've actually tried to alter the illustration a few times and it just looked skewed. Changing it to be closer to square also changes the relationship of each shapes to each other and to the negative space around it. My thought was to completely redesign it, come up with another logo that would fit a square. I just never got around to it.

@sarahdayan If you would like to take a shot at redesigning or altering that logo, you're more than welcome to do so. I just wasn't able to come up with a better alternative and I won't have much time to do so anytime soon 😞.

@sarahdayan
Copy link
Contributor Author

I will try take a spin at it 👍

@posva
Copy link
Member

posva commented Feb 7, 2020

Thank you Sarah!

@sarahdayan
Copy link
Contributor Author

sarahdayan commented Feb 7, 2020

What do you think @posva @geneparcellano? The logo is wider (see before/after), without skewing the angles.

vuefire

@geneparcellano
Copy link

@sarahdayan your changes gave me some ideas on how to make it even a little more square using some minor adjustments. I hope you don't mind me making some additional tweaks. Please see below.

On the left, I took your idea and adjusted the angles of the lines a little bit and moved some of the colors around.

On the right, I also changed the angles a little but kept the original configuration. I did have have to move the line on the fire a little to the right to compensate.

Let me know what you think. Also, feel free to make additional changes to these wherever you feel necessary.

image

@sarahdayan
Copy link
Contributor Author

sarahdayan commented Feb 8, 2020

@geneparcellano Neaaato! I think number 2 is definitely winning.

@posva ?

@posva
Copy link
Member

posva commented Feb 9, 2020

I do like the one with a bigger flame more :)

@geneparcellano
Copy link

@posva @sarahdayan here's a zip with the svg file of the logo on the right. Just let me know if there's anything else I can do.
logo-vuefire.zip

@sarahdayan
Copy link
Contributor Author

Thanks @geneparcellano, I've updated the PR 🙂 This looks badass.

@geneparcellano
Copy link

That looks awesome, thank you!

@posva
Copy link
Member

posva commented Feb 10, 2020

Thanks to both of you!
I wish it had rounder corners and some a bit of depth (like the Firebase one) without necessarily keeping Vue's color but it's still good and gives the project some identity :)

@posva posva merged commit 85be8f8 into vuejs:master Feb 10, 2020
@sarahdayan
Copy link
Contributor Author

@posva This can definitely be iterated on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logo suggestion

4 participants