Skip to content

Conversation

@playpianolikewoah
Copy link
Contributor

Actions don't

Did not make sense.

> Actions don't

Did not make sense.
@posva
Copy link
Member

posva commented Oct 30, 2017

Thanks for your interest in helping the docs, but that is valid English 🙂

The sky is blue, the sun isn't

@posva posva closed this Oct 30, 2017
@playpianolikewoah
Copy link
Contributor Author

playpianolikewoah commented Oct 30, 2017

@posva, I understand what the intention is, however, it is not valid English. When I first read it, it confused me.

If the docs said:

mutations have to be synchronous. Actions don't

It would make sense.
Also the abruptness of the second sentence will confuse the reader, as it did me.
Also the example you gave when you closed this PR is not the same structure.

You can see how it does not make sense if you complete the sentence.

Well, remember that mutations must be synchronous? Actions don't must be synchronous.

Changing the "must" to "have" and completing the sentence you get:

Well, remember that mutations have to be synchronous? Actions don't have to be.

Or as I suggested also works without changing the first sentence.

Either way the second sentence is unnecessarily abrupt.

@posva
Copy link
Member

posva commented Oct 30, 2017

You mean it could be

Well, remember that mutations must be synchronous? Actions mustn't
?

I personally think adding be synchrounous at the end makes the sentence heavy but I'm not native. WDYT @chrisvfritz @yyx990803

@playpianolikewoah
Copy link
Contributor Author

@posva That is an option. However, I offered other options that sound better, IMO.
I personally think:

mutations have to be synchronous. Actions don't.

Is the easiest fix.

@chrisvfritz
Copy link
Collaborator

@posva I might be late, but I like that as well. 🙂

mutations have to be synchronous. Actions don't.

@posva posva reopened this Nov 4, 2017
@posva posva added the documentation Improvements or additions to documentation label Nov 4, 2017
@ktsn ktsn merged commit a1a142c into vuejs:dev Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants