Skip to content

Conversation

@azat-io
Copy link
Contributor

@azat-io azat-io commented Oct 23, 2022

Close #1140

Copy link
Member

@Mister-Hope Mister-Hope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any packages which is in node_modules and which is being imported twice are supposed to be at ventor chunk, and only KNOWN library related to vue and vuepress are splited in to framework, this is the exactly same logic with vitepress. This benifits when user only change imported plugins or their project files(framework is the same), and if they only change markdown files, then framework and ventor will be the same.

However, we may need to add vue and vue-router as well, also improve detecting.

You fix might be valid, but it's only goal is to move everything related to framwork. which is not our goal.

@Mister-Hope
Copy link
Member

We may need to figure out why framework chunk is successfully splitted in the offiical docs, but not in user projects. I would appreciate if you can find issue related to it.

If you just want a quick fix, I would more prefer "revert" the original PR, instead of only making a meaningless workaround here.

@meteorlxy
Copy link
Member

It's obvious that in our repo, the @vuepress\/client, etc. won't be matched, because the final resolved path is not in the node_modules.

@Mister-Hope
Copy link
Member

@meteorlxy My pr only match package name, and it is actually matching, so official docs has framework chunk, however this is not happening in user projects, pretty strange.

@meteorlxy
Copy link
Member

Closing as we'll revert #1101 for now

@meteorlxy meteorlxy closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in built docs: Referapp.c20e2fa1.js:1 Uncaught ReferenceError: Cannot access 'j' before initialization

3 participants