fix(theme-default): align the font of line numbers with code blocks (close #124) #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
changed the title
KnorpelSenf
force-pushed
the
fix-displaced-line-numbers
branch
from
22368cc to
52c6f65
Compare
Member
Member
|
@KnorpelSenf Do you have time to handle this? Or I could help to update |
Member
|
I'm going to release a new version, so I have updated this pr to include the fix. |
meteorlxy
changed the title
meteorlxy
changed the title
Contributor
Author
|
Oh sorry for being late, couldn't have done it earlier than now. Thanks for taking over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124 by removing
'Courier New'as font which caused the issue.Must I adjust https://github.com/vuepress/vuepress-next/blob/e971d6aa216102befaa387e062d49b3632fe579c/packages/%40vuepress/theme-default/src/client/styles/_normalize.scss#L114 as well?
Not quite sure if the fix is in
core, maybe adjust the commit message when merging.