fix(cli): fix page files watching and add .git as default for monorepos#1685
fix(cli): fix page files watching and add .git as default for monorepos#1685Mister-Hope wants to merge 1 commit intomainfrom
Conversation
|
Adding The page watcher will walk completely throught .git/indexes. |
There was a problem hiding this comment.
Pull request overview
Updates VuePress defaults and dev-mode file watching to better handle monorepos by ignoring .git, and refines the chokidar ignored-path matching logic to avoid unnecessary directory traversal.
Changes:
- Add
!.gitto the defaultpagePatternsin core app options. - Update core test expectations for the new default
pagePatterns. - Adjust CLI dev page-file watcher ignore logic to match ignore patterns against relative paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/tests/app/resolveAppOptions.spec.ts | Updates the default options test to expect !.git in pagePatterns. |
| packages/core/src/app/resolveAppOptions.ts | Adds !.git to the runtime default pagePatterns. |
| packages/cli/src/commands/dev/watchPageFiles.ts | Refines ignored matching to use a consistent relative path for ignore/page matchers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pagePatterns = ['**/*.md', '!.vuepress', '!node_modules', '!.git'], | ||
| permalinkPattern = null, |
There was a problem hiding this comment.
The default pagePatterns has been updated here to include !.git, but the AppConfigCommon.pagePatterns JSDoc still documents the old default (missing !.git). Please update the JSDoc default in packages/core/src/types/app/options.ts to keep the public type docs consistent with runtime defaults.
No description provided.