Skip to content

feat(client): allow html title customization (close #338) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meteorlxy wants to merge 1 commit into from
Closed

feat(client): allow html title customization (close #338) #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vuepress/client/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const createVueApp: CreateVueAppFunction = async () => {
)
const pageFrontmatter = computed(() => resolvePageFrontmatter(pageData.value))
const pageHeadTitle = computed(() =>
resolvePageHeadTitle(pageData.value, siteLocaleData.value)
resolvePageHeadTitle.value(pageData.value, siteLocaleData.value)
)
const pageHead = computed(() =>
resolvePageHead(
Expand Down
15 changes: 9 additions & 6 deletions packages/@vuepress/client/src/injections/pageHeadTitle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inject } from 'vue'
import { inject, ref } from 'vue'
import type { ComputedRef, InjectionKey } from 'vue'
import type { PageData } from './pageData'
import type { SiteLocaleData } from './siteLocaleData'
Expand All @@ -19,9 +19,12 @@ export const usePageHeadTitle = (): PageHeadTitleRef => {
}

/**
* Title to displayed in `<head>` tag
* A function used for resolving the content of `head > title` tag
*
* This function is stored in a `ref`, so that users could change the
* function to customize the content of title tag.
*/
export const resolvePageHeadTitle = (
page: PageData,
siteLocale: SiteLocaleData
): PageHeadTitle => `${page.title ? `${page.title} | ` : ``}${siteLocale.title}`
export const resolvePageHeadTitle = ref(
(page: PageData, siteLocale: SiteLocaleData) =>
`${page.title ? `${page.title} | ` : ``}${siteLocale.title}`
)