Skip to content

feat(plugin-blog): use new api for hotReload#643

Merged
Mister-Hope merged 2 commits intomainfrom
plugin-blog
Mar 11, 2026
Merged

feat(plugin-blog): use new api for hotReload#643
Mister-Hope merged 2 commits intomainfrom
plugin-blog

Conversation

@Mister-Hope
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 11, 2026 06:17
@coveralls
Copy link

coveralls commented Mar 11, 2026

Pull Request Test Coverage Report for Build 22941927800

Details

  • 1 of 33 (3.03%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 71.751%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/blog/plugin-blog/src/node/blogPlugin.ts 1 33 3.03%
Files with Coverage Reduction New Missed Lines %
plugins/blog/plugin-blog/src/node/blogPlugin.ts 1 42.31%
Totals Coverage Status
Change from base Build 22936278782: 0.4%
Covered Lines: 1539
Relevant Lines: 1972

💛 - Coveralls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates @vuepress/plugin-blog to rely on VuePress’ onPageUpdated hook for hot-reload behavior, removing the previous chokidar-based watcher and improving JSDoc/type documentation in shared and node utilities.

Changes:

  • Remove chokidar usage and dependency; switch hot reload logic to onPageUpdated.
  • Refactor incremental update logic for adding/removing generated blog pages on updates.
  • Expand/clarify JSDoc for shared blog maps and node-side store/page-map utilities.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-lock.yaml Removes chokidar from lockfile for plugin-blog importer.
plugins/blog/plugin-blog/package.json Drops chokidar dependency.
plugins/blog/plugin-blog/src/node/blogPlugin.ts Implements hot reload via onPageUpdated and incremental page add/remove logic.
plugins/blog/plugin-blog/src/node/store.ts Adds bilingual JSDoc clarifying store semantics and helper behavior.
plugins/blog/plugin-blog/src/node/getPagesMap.ts Adds bilingual JSDoc for page grouping helper.
plugins/blog/plugin-blog/src/shared/internal.ts Adds richer type-level documentation/examples for internal blog maps.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@Mister-Hope Mister-Hope merged commit 1d2556b into main Mar 11, 2026
26 checks passed
@Mister-Hope Mister-Hope deleted the plugin-blog branch March 11, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants