feat(plugin-blog): use new api for hotReload#643
Merged
Mister-Hope merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22941927800Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates @vuepress/plugin-blog to rely on VuePress’ onPageUpdated hook for hot-reload behavior, removing the previous chokidar-based watcher and improving JSDoc/type documentation in shared and node utilities.
Changes:
- Remove
chokidarusage and dependency; switch hot reload logic toonPageUpdated. - Refactor incremental update logic for adding/removing generated blog pages on updates.
- Expand/clarify JSDoc for shared blog maps and node-side store/page-map utilities.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Removes chokidar from lockfile for plugin-blog importer. |
| plugins/blog/plugin-blog/package.json | Drops chokidar dependency. |
| plugins/blog/plugin-blog/src/node/blogPlugin.ts | Implements hot reload via onPageUpdated and incremental page add/remove logic. |
| plugins/blog/plugin-blog/src/node/store.ts | Adds bilingual JSDoc clarifying store semantics and helper behavior. |
| plugins/blog/plugin-blog/src/node/getPagesMap.ts | Adds bilingual JSDoc for page grouping helper. |
| plugins/blog/plugin-blog/src/shared/internal.ts | Adds richer type-level documentation/examples for internal blog maps. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.