Open
Conversation
Pull Request Test Coverage Report for Build 23079090950Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes previously applied Vite optimization / SSR bundler-option adjustments across multiple plugins and the default theme, and updates a few client-side dynamic imports. It also tweaks dependency declarations for some packages.
Changes:
- Removed multiple
extendsBundlerOptionshooks that were adding ViteoptimizeDeps.*andssr.*overrides. - Updated some dynamic imports to include
webpackChunkNameannotations. - Adjusted package dependency declarations and updated
pnpm-lock.yamlaccordingly.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/highlighter-helper/package.json | Moves @vuepress/helper from peer deps to dev deps. |
| themes/theme-default/src/node/defaultTheme.ts | Removes Vite optimize-deps exclusion for @theme. |
| plugins/tools/plugin-redirect/src/node/redirectPlugin.ts | Removes Vite SSR noExternal bundler hook. |
| plugins/search/plugin-slimsearch/src/node/slimsearchPlugin.ts | Removes Vite optimize/SSR bundler hook. |
| plugins/search/plugin-meilisearch/src/node/meilisearchPlugin.ts | Removes Vite SSR external bundler hook. |
| plugins/search/plugin-meilisearch/src/client/components/MeiliSearch.ts | Adds webpackChunkName to dynamic import. |
| plugins/search/plugin-docsearch/src/client/components/DocSearch.ts | Adds webpackChunkName to dynamic import. |
| plugins/pwa/plugin-pwa/src/node/pwaPlugin.ts | Removes Vite optimize/SSR bundler adjustments; keeps dev-server customization. |
| plugins/markdown/plugin-revealjs/src/node/revealJsPlugin.ts | Removes Vite optimize/SSR bundler adjustments. |
| plugins/markdown/plugin-markdown-file-tree/package.json | Removes unused @vuepress/helper dependency. |
| plugins/markdown/plugin-markdown-chart/src/node/markdownChartPlugin.ts | Removes Vite optimize/SSR bundler adjustments. |
| plugins/markdown/plugin-markdown-chart/src/client/components/Mermaid.ts | Switches Mermaid dynamic import target to mermaid. |
| plugins/features/plugin-photo-swipe/src/node/photoSwipePlugin.ts | Removes Vite optimize/SSR bundler adjustments. |
| plugins/features/plugin-medium-zoom/package.json | Removes unused @vuepress/helper dependency. |
| plugins/features/plugin-icon/src/node/iconPlugin.ts | Removes Vite SSR noExternal bundler hook and custom-element config. |
| plugins/features/plugin-copyright/src/node/copyrightPlugin.ts | Removes Vite SSR noExternal bundler hook. |
| plugins/features/plugin-copy-code/src/node/copyCodePlugin.ts | Removes Vite SSR noExternal bundler hook. |
| plugins/features/plugin-catalog/src/node/catalogPlugin.ts | Removes Vite SSR noExternal bundler hook. |
| plugins/development/plugin-reading-time/src/node/readingTimePlugin.ts | Removes Vite SSR noExternal bundler hook. |
| plugins/blog/plugin-comment/src/node/commentPlugin.ts | Removes Vite optimize/SSR bundler adjustments. |
| plugins/blog/plugin-blog/src/node/blogPlugin.ts | Removes Vite SSR noExternal bundler hook. |
| pnpm-lock.yaml | Lockfile updates reflecting dependency/bundler-hook removals. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| "devDependencies": { | ||
| "@vuepress/helper": "workspace:*" | ||
| }, | ||
| "peerDependencies": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.