Merged
Conversation
Pull Request Test Coverage Report for Build 23839173097Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts @vuepress/plugin-slimsearch’s worker build/layout so the generated worker script is sourced from the correct location, and consolidates shared result/worker typings into src/shared to avoid client/worker duplication.
Changes:
- Update worker build entries/paths (split dev vs build worker) and update node-side
WORKER_FILEaccordingly. - Move/search worker utility code into
src/worker/utilsand update imports/tests. - Consolidate shared result/worker types into
src/sharedand update client/worker type imports.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/search/plugin-slimsearch/tsdown.config.ts | Adjusts tsdown entries to build worker artifacts in the intended locations. |
| plugins/search/plugin-slimsearch/tests/getMatchedContent.spec.ts | Updates test import path to the new worker utils location. |
| plugins/search/plugin-slimsearch/src/worker/utils/index.ts | Adds a barrel export for worker utility functions. |
| plugins/search/plugin-slimsearch/src/worker/utils/getSuggestions.ts | Switches to shared type imports for worker options/items. |
| plugins/search/plugin-slimsearch/src/worker/utils/getSearchResults.ts | Switches to shared type imports for search result typing. |
| plugins/search/plugin-slimsearch/src/worker/utils/getMatchedContent.ts | Switches to shared type imports for Word. |
| plugins/search/plugin-slimsearch/src/worker/dev.ts | Points dev worker to new utils barrel + shared typings. |
| plugins/search/plugin-slimsearch/src/worker/build.ts | Points build worker to new utils barrel + shared typings. |
| plugins/search/plugin-slimsearch/src/shared/worker.ts | Fixes IndexItem import to local shared module. |
| plugins/search/plugin-slimsearch/src/shared/result.ts | Introduces shared result/word/match typings. |
| plugins/search/plugin-slimsearch/src/shared/index.ts | Re-exports new shared result/worker types. |
| plugins/search/plugin-slimsearch/src/node/utils.ts | Updates WORKER_FILE to the new built worker path. |
| plugins/search/plugin-slimsearch/src/client/utils/getResultPath.ts | Switches MatchedItem typing import to shared types. |
| plugins/search/plugin-slimsearch/src/client/utils/createSearchWorker.ts | Updates dev worker URL and migrates query/result typings to shared types. |
| plugins/search/plugin-slimsearch/src/client/typings/index.ts | Removes client typings barrel (types now come from shared). |
| plugins/search/plugin-slimsearch/src/client/helpers/search.ts | Switches SearchResult/WorkerSearchOptions typing import to shared types. |
| plugins/search/plugin-slimsearch/src/client/composables/useResults.ts | Switches SearchResult typing import to shared types. |
| plugins/search/plugin-slimsearch/src/client/composables/useResultHistory.ts | Switches MatchedItem/Word typing import to shared types. |
| plugins/search/plugin-slimsearch/src/client/components/SearchResult.ts | Switches MatchedItem/Word typing import to shared types. |
plugins/search/plugin-slimsearch/src/client/utils/createSearchWorker.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.