This repository was archived by the owner on May 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 329
feature/2167 #390
Merged
Merged
feature/2167 #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
Contributor
Author
|
ResuBaka
reviewed
Dec 30, 2019
Contributor
Author
|
Thanks! OK I've used # as for now. npm is definitely the right idea: https://www.npmjs.com/package/storefront-query-builder what's your npm login? @andrzejewsky and yours? I'll add you to the VueStorefront org on npm guys |
Collaborator
gibkigonzo
reviewed
Dec 31, 2019
ResuBaka
reviewed
Jan 7, 2020
| "sharp": "^0.23.4", | ||
| "soap": "^0.25.0", | ||
| "storefront-query-builder": "https://github.com/DivanteLtd/storefront-query-builder.git", | ||
| "storefront-query-builder": "^0.0.9", |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to 0.0.*
So we don't get possible breaking changes, as 0.1.0 could have breaking changes in it when you go after semver versioning.
…uilder`; Full TS coverage won't be added (it's planned for `storefront-api` project instead)
b51dc60 to
cc1597f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/DivanteLtd/vue-storefront/pull/3962/files
I've moved the ElasticSearch query construction to the api. There is an additional parameter
request_format; whensearch-querythe Elastic query is constructed server-side - on the API level.I've moved the Query Builder to separate repository: https://github.com/DivanteLtd/storefront-query-builder which is now shared with
vue-storefrontand will be shared withstorefront-apiprojects.This is Work in Progress and not ready to merge. Bc. some config variables have currently missed the query is being constructed wrong way and it results with no aggregation and no products.
TODO:
queryBuilderin thegraphqlresolvers to use this newstorefront-query-builderlibrary,