Skip to content

Conversation

@pkarw
Copy link
Collaborator

@pkarw pkarw commented Dec 28, 2019

Related Issues

related PR: vuestorefront/vue-storefront-api#390
related Project: https://github.com/DivanteLtd/storefront-query-builder/
closes #2167 and partially #2232

  1. I've added new SearchAdapter api-search-query which is just passing the raw SearchQuery to the backend - no bodybuilder imported
  2. I've moved the SearchQuery and queryBuilder to separate repo https://github.com/DivanteLtd/storefront-query-builder which is now shared between vue-storefront and vue-storefront-api and will be shared with storefront-api as well
  3. For backward compatibility - there is just one change required: config.api from api-search-query to api. No other changes required.
  4. I've removed amp-renderer module (it's disabled in the src/modules/index.ts)
  5. I've removed google-tag-manager module (it's disabled in the src/modules/index.ts)

Note: If you still need bodybuilder it's in the package.json so you can just use import bodybuilder from 'bodybuilder' - that's it.

Testing instruction

Overall effect: simplified business logic (no Elastic DSL construction in the frontend); -400kB over app.js bundle

Next steps:

  • fix Unit tests,
  • update changelog,
  • update upgrade notes,
  • fix warnings caused by amp-renderer module disabled
  • finish the vue-storefront-api part - currently, it's missing some important config variables so the final query is not properly built,
  • add a readme file to the storefront-query-builder and continue the extension works as requested in Extendable Elasticsearch queries #3934

@pkarw pkarw changed the base branch from master to develop December 28, 2019 13:32
@pkarw pkarw changed the title [WIP]: Feature/2167 [WIP]: bodybuilder removed (#2167), bundle size optimizations (#2232) Dec 28, 2019
@pkarw pkarw changed the title [WIP]: bodybuilder removed (#2167), bundle size optimizations (#2232) bodybuilder removed (#2167), bundle size optimizations (#2232) Dec 30, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Dec 30, 2019
Copy link
Contributor

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good work! works fine @pkarw

@andrzejewsky andrzejewsky merged commit 72d7768 into develop Jan 13, 2020
@filrak filrak deleted the feature/2167 branch March 19, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants