Skip to content

Conversation

@ngongoll
Copy link
Contributor

i put the perPage value in the config file to be more flexible. i have only 3 columns in my categories and loading 50 perPage return uneven rows.

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ngongoll I think it's fine. I'm just wondering if we should add this feature to develop (1.11) as well (?) @andrzejewsky @filrak

@andrzejewsky
Copy link
Contributor

@pkarw basically it's a theme thing, I wouldn't put options like this to the config file. When you create a theme you calling/dispatching this action and you can decide how many items do you want to display by arguments passed to the action. What do you think @pkarw @filrak ?

@patzick patzick changed the base branch from master to develop September 30, 2019 07:14
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @andrzejewsky. We definitely should have in theme config file specific for the theme.
However this is a nice work Niels, would you mind to extend it a little bit and add that kind of config?
@filrak, please suggest wherein theme put it :)

@filrak
Copy link
Collaborator

filrak commented Oct 3, 2019

Having theme.config.js in a theme root could be very useful indeed ;)

@andrzejewsky andrzejewsky added this to the 1.11.0 milestone Oct 29, 2019
@lysy-vlc lysy-vlc mentioned this pull request Nov 14, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants