Feature/3630

[lysy-vlc]

Related issues

#3630

Short description and why it's useful

I've created config which is used to change features exclusively for specific theme.
At this point it conditions only the number of products loading per page.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

• Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
• RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
• Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

• No upgrade steps required (100% backward compatibility and no breaking changes)

• I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

• I read and followed contribution rules

[pkarw]

I think we shouldn't remove the pageSize attribute - rather add the page + pageSize + set the default value of it to the config variable

[patzick]

Overall it's an excellent approach to have the theme config. But we never can assume, that everyone would have this config and same structure, as it's specific for the theme.
So the only use of it should be in the theme folder and never in core files, otherwise it may cause many troubles for implementing projects.

[andrzejewsky]

@adkamil from my side, please maybe move these theme config settings to the template constants. It's not perfect but theme config is the new feature and we don't want to introduce it now and here. Thanks!

[lysy-vlc]

Alrighty! I think this solution meets your approach.