Skip to content

Conversation

@benjick
Copy link
Contributor

@benjick benjick commented Nov 12, 2019

Short description and why it's useful

Before this localhost/se/simple-product would redirect to localhost/p/xxx/yyy/zzz. This change redirects to localhost/se/configurable-product.

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

@benjick benjick force-pushed the bugfix/redirect-from-simple-product-using-url_path branch from 5df5dc4 to 1ade583 Compare November 12, 2019 07:52
@andrzejewsky
Copy link
Contributor

hey @benjick could please change base to release/v1.11?

@benjick benjick changed the base branch from develop to release/v1.11 November 12, 2019 08:51
@benjick benjick force-pushed the bugfix/redirect-from-simple-product-using-url_path branch from 9e34596 to fd2e449 Compare November 12, 2019 08:54
@benjick
Copy link
Contributor Author

benjick commented Nov 12, 2019

@andrzejewsky did I do it right?

I did git rebase upstream/release/v1.11, not sure how to get those three commits out

@benjick benjick force-pushed the bugfix/redirect-from-simple-product-using-url_path branch from fd2e449 to e9a167b Compare November 12, 2019 09:40
@benjick
Copy link
Contributor Author

benjick commented Nov 12, 2019

Redid it now, sorry about that

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right; good point

@andrzejewsky andrzejewsky self-requested a review November 13, 2019 12:51
@andrzejewsky andrzejewsky merged commit e495955 into vuestorefront:release/v1.11 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants