Skip to content

Conversation

@gibkigonzo
Copy link
Contributor

Short description and why it's useful

I know that good practice is to use commit instead of mutation, but this commit kills vue-devtools. 90% of commits in timetravel in vue-devtools are REGISTER_MAPPING. I think that we don't even want to check previous state of route mapping because it's more like data aggregate. Vue-devtools makes copy of vuex state with every commit to allow timetravel and sometimes it can't handle this (check screen).

Screenshots of visual changes before/after (if there are any)

screen1

Which environment this relates to

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and currently important rules acceptance

Copy link
Collaborator

@pkarw pkarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m ok with this change. Please maybe just leave a comment pointing this PR to not let us forget why we did intentionally skip this good practice in here ;)

@pkarw pkarw requested a review from andrzejewsky December 7, 2019 05:39
@pkarw pkarw added this to the 1.12.0-rc1 milestone Dec 11, 2019
@pkarw
Copy link
Collaborator

pkarw commented Dec 27, 2019

@andrzejewsky as for me this is ok to merge - looking for your second approval :)

@andrzejewsky
Copy link
Contributor

looks good for me, sometimes it breaks even the dev-tools

@gibkigonzo good work! even though.... again - CHANGELOG!! 😄

@andrzejewsky andrzejewsky merged commit cf1ace7 into vuestorefront:develop Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants