Feature/remove commit register mapping

CHANGELOG.md

@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed / Improved
 - Optimized `translation.processor` to process only enabled locale CSV files - @pkarw (#3950)
+- Remove commit register mapping - @gibkigonzo (#3875)
 
 ## [1.11.0] - 2019.12.20
 

core/modules/url/store/actions.ts

@@ -1,6 +1,5 @@
 import { UrlState } from '../types/UrlState'
 import { ActionTree } from 'vuex';
-import * as types from './mutation-types'
 // you can use this storage if you want to enable offline capabilities
 import { cacheStorage } from '../'
 import queryString from 'query-string'
@@ -13,8 +12,10 @@ import storeCodeFromRoute from '@vue-storefront/core/lib/storeCodeFromRoute'
 // it's a good practice for all actions to return Promises with effect of their execution
 export const actions: ActionTree<UrlState, any> = {
   // if you want to use cache in your module you can load cached data like this
-  async registerMapping ({ commit }, { url, routeData }: { url: string, routeData: any}) {
-    commit(types.REGISTER_MAPPING, { url, routeData })
+  async registerMapping ({ state }, { url, routeData }: { url: string, routeData: any}) {
+    if (!state.dispatcherMap[url]) {
+      state.dispatcherMap[url] = routeData
+    }
     try {
       await cacheStorage.setItem(normalizeUrlPath(url), routeData, null, config.seo.disableUrlRoutesPersistentCache)
     } catch (err) {

core/modules/url/store/index.ts

@@ -1,12 +1,10 @@
 import { Module } from 'vuex'
 import { UrlState } from '../types/UrlState'
-import { mutations } from './mutations'
 import { actions } from './actions'
 import { state } from './state'
 
 export const urlStore: Module<UrlState, any> = {
   namespaced: true,
-  mutations,
   actions,
   state
 }

core/modules/url/test/unit/store/actions.spec.ts

@@ -1,4 +1,3 @@
-import * as types from '@vue-storefront/core/modules/url/store/mutation-types';
 import { cacheStorage } from '@vue-storefront/core/modules/recently-viewed/index';
 import { actions as urlActions } from '../../../store/actions';
 import { currentStoreView, localizedDispatcherRouteName } from '@vue-storefront/core/lib/multistore';
@@ -75,17 +74,15 @@ describe('Url actions', () => {
   describe('registerMapping action', () => {
     it('should call register mapping mutation', async () => {
       const contextMock = {
-        commit: jest.fn()
+        state: {
+          dispatcherMap: {}
+        }
       };
       const result = await (urlActions as any).registerMapping(contextMock, {
         url,
         routeData
       });
 
-      expect(contextMock.commit).toHaveBeenCalledWith(types.REGISTER_MAPPING, {
-        url,
-        routeData
-      });
       expect(result).toEqual(routeData);
     });
   });