Skip to content

Conversation

@gibkigonzo
Copy link
Contributor

Short Description and Why It's Useful

Two changes:

  • in asyncData we can have prevoius route in rootState.route. Thats because asyncData is triggered before we enter route and before 'vuex-router-sync' can be updated. So this change adds getter 'url/getCurrentRoute' which has always newest route data, because it is updated before asyncData in client-entry and server-entry.
  • in 'core/lib/search.ts' we get data from cache but still request is triggered. So in this change if we have request in cache, then we don't trigger request.

Screenshots of Visual Changes before/after (if There Are Any)

Cached requests before:
before

Cached requests after:
after

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

tkostuch added 3 commits February 12, 2020 12:34
…ecause asyncData is triggered before we enter route and before 'vuex-router-sync' can be updated.

 So this change adds getter 'url/getCurrentRoute' which has always newest route data, because it is updated before asyncData in client-entry and server-entry.
- in 'core/lib/search.ts' we get data from cache but still request is triggered. So in this change if we have request in cache, then we don't trigger request.
@andrzejewsky
Copy link
Contributor

@gibkigonzo changelog 💂

@gibkigonzo
Copy link
Contributor Author

@andrzejewsky done :)

@andrzejewsky andrzejewsky merged commit afddd2f into vuestorefront:hotfix/v1.11.2 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants