Skip to content

Conversation

@gibkigonzo
Copy link
Contributor

Short Description and Why It's Useful

related: #4077
This is revert for changes from #4077. For getters we should use route that is not resolving. When we click product from category page getter will update because rootGetters['url/getCurrentRoute'] will change, but route is still in state beforeResolve.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@andrzejewsky
Copy link
Contributor

@gibkigonzo CHANGELOG 🗡

@gibkigonzo gibkigonzo merged commit 2935e9e into vuestorefront:hotfix/v1.11.2 Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants