Skip to content

Conversation

@haelbichalex
Copy link
Contributor

@haelbichalex haelbichalex commented Feb 18, 2020

Short Description and Why It's Useful

The current regex also matches for urls ending with for example ico, without the dot:
https://www.regextester.com/?fam=114754

The updated one checks if there's a . before the given file extension list:
https://www.regextester.com/?fam=114755

In my case I got a 404 page result because my path was something like /testico.

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@andrzejewsky
Copy link
Contributor

@haelbichalex Thanks! please just update the changelog and it's ready to be merged in.

@haelbichalex
Copy link
Contributor Author

@andrzejewsky Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants