Skip to content

Update NOT_ALLOWED_SSR_EXTENSIONS_REGEX to specifically look for a dot before the file extension #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Update NOT_ALLOWED_SSR_EXTENSIONS_REGEX to specifically look for a dot before the file extension #4100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1a76d0
Update NOT_ALLOWED_SSR_EXTENSIONS_REGEX to specifically look for a do…
Feb 18, 2020
8315f87
Update changelog to add #4100
Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- findConfigurableChildAsync - return best match for configurable variant - @gibkigonzo (#4042)
- use storeCode for mappingFallback url - @gibkigonzo (#4050)
- `getVariantWithLowestPrice` uses inexistent `final_price` property - @cewald (#4091)
- Fixed `NOT_ALLOWED_SSR_EXTENSIONS_REGEX` to only match with file extensions having a dot - @haelbichalex (#4100)

### Changed / Improved
- Optimized `translation.processor` to process only enabled locale CSV files - @pkarw (#3950)
Expand Down
2 changes: 1 addition & 1 deletion config/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dynamicConfigInclude": [],
"elasticCacheQuota": 4096,
"ssrDisabledFor": {
"extensions": [".png", ".gif", ".jpg", ".jpeg", ".woff", ".eot", ".woff2", ".ttf", ".svg", ".css", ".js", ".json", ".ico", ".tiff", ".tif", ".raw"]
"extensions": ["png", "gif", "jpg", "jpeg", "woff", "eot", "woff2", "ttf", "svg", "css", "js", "json", "ico", "tiff", "tif", "raw"]
},
"trace": {
"enabled": false,
Expand Down
2 changes: 1 addition & 1 deletion core/scripts/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const compileOptions = {
escape: /{{([^{][\s\S]+?[^}])}}/g,
interpolate: /{{{([\s\S]+?)}}}/g
}
const NOT_ALLOWED_SSR_EXTENSIONS_REGEX = new RegExp(`(.*)(${config.server.ssrDisabledFor.extensions.join('|')})$`)
const NOT_ALLOWED_SSR_EXTENSIONS_REGEX = new RegExp(`^.*\\.(${config.server.ssrDisabledFor.extensions.join('|')})$`)

const isProd = process.env.NODE_ENV === 'production'
process['noDeprecation'] = true
Expand Down