Skip to content

Conversation

@cewald
Copy link
Contributor

@cewald cewald commented Mar 5, 2020

Related Issues

When you select a product configuration on product-details page the product/setCurrent action resets the gallery using own commit. It would be more consistent if it is using the existing setProductGallery action, which contains some more logic.

Short Description and Why It's Useful

For example: In my case the configurable childs data might not contain the same product images as the parent and the images simply disappear if I have config.products.gallery.mergeConfigurableChildren disabled. If I use the setProductGallery action it will be handled correctly, like on page load.

Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To

Check your case. In case of any doubts please read about Release Cycle

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@andrzejewsky
Copy link
Contributor

@cewald can you resolve conflicts?

@andrzejewsky andrzejewsky merged commit 9c834b2 into vuestorefront:develop Mar 20, 2020
@cewald cewald deleted the feature/update-product-gallery-on-change-correctly branch March 20, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants