Skip to content

Use setProductGallery in product/setCurrent to use logic of the action #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Use setProductGallery in product/setCurrent to use logic of the action #4153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89f36d7
Use `setProductGallery` in `product/setCurrent` to use the whole logi…
Mar 5, 2020
2ae1f2a
Update CHANGELOG.md
Mar 5, 2020
cfd18ec
Merge branch 'develop' into feature/update-product-gallery-on-change-…
Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed problem with not showing error message when placing an order fails - @qiqqq
- Invoking afterCacheInvalidated server hook in a proper moment - @Fifciu (#4176)
- Fixed `cart/isVirtualCart` to return `false` when cart is empty - @haelbichalex(#4182)
- Use `setProductGallery` in `product/setCurrent` to use logic of the action - @cewald (#4153)

### Changed / Improved

Expand Down
2 changes: 1 addition & 1 deletion core/modules/catalog/store/product/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ const actions: ActionTree<ProductState, RootState> = {
const productUpdated = Object.assign({}, originalProduct, productVariant)
populateProductConfigurationAsync(context, { product: productUpdated, selectedVariant: productVariant })
if (!config.products.gallery.mergeConfigurableChildren) {
context.commit(types.PRODUCT_SET_GALLERY, attributeImages(productVariant))
context.dispatch('setProductGallery', { product: productUpdated })
}
context.commit(types.PRODUCT_SET_CURRENT, Object.assign({}, productUpdated))
return productUpdated
Expand Down