Skip to content

Conversation

@carlokok
Copy link
Contributor

Short Description and Why It's Useful

Currently, when using custom options, the html ids of the radio buttons overlap if the id of their value (option_type_id) is the same. This patch makes the html ids unique, making the option usable independent.

Screenshots of Visual Changes before/after (if There Are Any)

afbeelding

Before, changing geheugenkaart also changes Behuizing, now they work independent. (Custom options json https://gist.github.com/carlokok/db1b40eeb7bc04683736a0a02d4b6281)

Which Environment This Relates To

  • Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
  • RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
  • Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

  • No upgrade steps required (100% backward compatibility and no breaking changes)
  • I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

Contribution and Currently Important Rules Acceptance

@gibkigonzo
Copy link
Contributor

@carlokok thanks for this pr, can you change base to hotfix/v1.11.3?

@carlokok carlokok changed the base branch from develop to hotfix/v1.11.3 March 25, 2020 19:02
@carlokok carlokok changed the base branch from hotfix/v1.11.3 to develop March 25, 2020 19:03
@carlokok carlokok force-pushed the bugfix/unique_id_custom_option branch from 509b673 to 7ebf78c Compare March 26, 2020 08:21
@carlokok carlokok changed the base branch from develop to hotfix/v1.11.3 March 26, 2020 08:21
@andrzejewsky andrzejewsky merged commit e1b133e into vuestorefront:hotfix/v1.11.3 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants