Skip to content

When having multiple custom options with overlapping option_type_id v… #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2020
Merged

When having multiple custom options with overlapping option_type_id v… #4196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9b7624
When having multiple custom options with overlapping option_type_id v…
carlokok Mar 26, 2020
7ebf78c
0: Updated changelog
carlokok Mar 24, 2020
dc6f3f4
Merge branch 'hotfix/v1.11.3' into bugfix/unique_id_custom_option
andrzejewsky Mar 28, 2020
64cef79
Merge branch 'hotfix/v1.11.3' into bugfix/unique_id_custom_option
andrzejewsky Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- The default config file is now in more human-readable format - @juho-jaakkola (#4197)

### Fixed
- Fixes when having multiple custom options with overlapping option_type_id values, selecting 1 changes the others - @carlokok (#4196)
- Update eslint and fix code style. - @gibkigonzo (#4179 #4181)
- add missing cache tags for category and product - @gibkigonzo (#4173)
- add ssrAppId to avoid second meta render on csr - @gibkigonzo (#4203)
Expand Down
4 changes: 2 additions & 2 deletions src/themes/default/components/core/ProductCustomOptions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
type="radio"
class="m0 no-outline"
:name="('customOption_' + option.option_id)"
:id="('customOption_' + opval.option_type_id)"
:id="('customOption_' + option.option_id + '_' + opval.option_type_id)"
focus
:value="opval.option_type_id"
v-model="inputValues[('customOption_' + option.option_id)]"
><label class="pl10 lh20 h4 pointer" :for="('customOption_' + opval.option_type_id)" v-html="opval.title" />
><label class="pl10 lh20 h4 pointer" :for="('customOption_' + option.option_id +'_' + opval.option_type_id)" v-html="opval.title" />
</div>
</div>
<div v-if="option.type === 'checkbox'">
Expand Down