fix: issue with custom methods in new module #7056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 212aa87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Base automatically changed from
refactor/IN-3860-tsdocs
to
feat/moduleFromEndpoints
March 5, 2024 08:44
lsliwaradioluz
approved these changes
Mar 5, 2024
| * Generates a `RequestSender` function configured according to the provided options. | ||
| * | ||
| * @remarks | ||
| * This function abstracts away the details of constructing request URLs, merging configurations, |
Collaborator
There was a problem hiding this comment.
Can we just link to the RequestSender interface docs? I feel like you're repeating here what you've just written there
Collaborator
Author
There was a problem hiding this comment.
imo this function might be used directly by the developers so it would be good to have it in here as well :)
Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>
WojtekTheWebDev
added a commit
that referenced
this pull request
Mar 11, 2024
* refactor: rename module dir to modules * feat: new SDK module - moduleFromEndpoints * Update packages/sdk/src/__tests__/integration/modules/moduleFromEndpoints.spec.ts Co-authored-by: Tomasz Góral <tomasz.gl69@gmail.com> * feat: HTTP Client for moduleForEndpoints (#7053) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * test: update tests based on the review * fix issue with URL class and urls as paths * add test for axios * add computed headers to http client * update tsdocs * feat: add customizable error handler (#7054) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * update error handler due to feedback * update tsdocs * refactor default http client * use unknown instead of any * add method name to error handler * update tsdocs * apply review suggestions * refactor: simplification & improve tsdocs (#7055) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * refactor: improve tsdocs * test non-object params * add comment * add module types to api extractor * fix: issue with custom methods in new module (#7056) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * refactor: improve tsdocs * fix: issue with custom methods in new module * test: additonal tests * fix issue with losing tsdocs * rename file * missing import * include credentials * Update packages/sdk/src/modules/moduleFromEndpoints/types.ts Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com> --------- Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com> * update tsdocs * rename module to middlewareModule --------- Co-authored-by: Tomasz Góral <tomasz.gl69@gmail.com> Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>
WojtekTheWebDev
added a commit
that referenced
this pull request
Mar 12, 2024
* refactor: rename module dir to modules * feat: new SDK module - moduleFromEndpoints * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * refactor: improve tsdocs * fix: issue with custom methods in new module * test: additonal tests * fix issue with losing tsdocs * prerelease * fix header type * revert last fix * chore: bump package * refactor: use moduleFromEndpoints in next * refactor: update shared * refactor: update nuxt package * refactor: easeier setup * chore: fix version * Update packages/sdk/src/__tests__/integration/modules/moduleFromEndpoints.spec.ts Co-authored-by: Tomasz Góral <tomasz.gl69@gmail.com> * feat: HTTP Client for moduleForEndpoints (#7053) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * test: update tests based on the review * fix issue with URL class and urls as paths * add test for axios * add computed headers to http client * update tsdocs * feat: add customizable error handler (#7054) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * update error handler due to feedback * update tsdocs * refactor default http client * use unknown instead of any * add method name to error handler * update tsdocs * apply review suggestions * refactor: simplification & improve tsdocs (#7055) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * refactor: improve tsdocs * test non-object params * add comment * add module types to api extractor * fix: issue with custom methods in new module (#7056) * feat: default behaviour of HTTP Client * remove isomorphic-fetch from depts * full implementation of HTTP client * feat: add customizable error handler * await error handler * refactor: improve tsdocs * fix: issue with custom methods in new module * test: additonal tests * fix issue with losing tsdocs * rename file * missing import * include credentials * Update packages/sdk/src/modules/moduleFromEndpoints/types.ts Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com> --------- Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com> * bump version * use new version * refactor: use getRequestHeaders naming for both nuxt and next * update tsdocs * rename module to middlewareModule * bump sdk package * use middlewareModule naming * use strict mode in storefront packages * deprecate getCookieHeader * refactor * first try to fix the yarn.lock * add prettier * revert * update sdk package * exit pre mode and refactor * add prettier * add changelogs and bump packages * apply review suggestions * apply review suggestions pt2 --------- Co-authored-by: Tomasz Góral <tomasz.gl69@gmail.com> Co-authored-by: Łukasz Śliwa <39009379+lsliwaradioluz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Fix the issue with extensions and new module.
Additionally, rename getHttpClient into getRequestSender to avoid conflicts.
📝 Checklist