Skip to content

feat(Button): add new component#166

Merged
johnleider merged 15 commits intomasterfrom
feat/button-component
Mar 24, 2026
Merged

feat(Button): add new component#166
johnleider merged 15 commits intomasterfrom
feat/button-component

Conversation

@johnleider
Copy link
Copy Markdown
Member

@johnleider johnleider commented Mar 24, 2026 •
edited
Loading

Summary

  • New headless Button compound component with disabled, readonly, passive, and loading states
  • Button.Group for toggle selection with v-model, single/multi-select, and mandatory support
  • Loading grace period (1s) prevents UI flicker on fast operations
  • Icon accessibility enforcement with aria-label warnings for icon-only buttons
  • Hidden form input for toggle value submission
  • Documentation page with 5 interactive examples
  • 39 tests covering all states, group integration, and loading behavior

Sub-components

Component Purpose
Button.Root Primary element via Atom (button/anchor/router-link)
Button.Group Selection container for toggle groups
Button.Loading Loading content (visible after grace period)
Button.Content Default content (fallback when not loading)
Button.Icon Icon wrapper with accessibility
Button.HiddenInput Hidden form input for toggle values

Test plan

  • 39 unit tests passing (states, group, loading grace period, icon a11y, hidden input)
  • Lint clean
  • Typecheck clean (only pre-existing Splitter errors)
  • Package builds successfully
  • Playwright visual verification of all 4 states
  • Manual review of docs page at /components/actions/button

@johnleider
fix(Splitter): preserve user styles on Root, Panel, and Handle
21d37a5 
The v-bind spread `{ ...attrs, ...slotProps.attrs }` silently
overwrote user-provided :style with internal styles. Add explicit
:style array binding to merge user, slot, and component styles.

Same fix applied to Slider in 5216ff0.
@johnleider
feat(Button): add new component
b2da84f
@johnleider johnleider self-assigned this Mar 24, 2026
@johnleider johnleider added this to the v0.2.0 milestone Mar 24, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026 •
edited
Loading

Open in StackBlitz

commit: d81dfea

johnleider added 12 commits March 23, 2026 20:14
@johnleider
fix(Button): address code review feedback
239cb28 
Move all imports to regular script blocks, fix icon-only detection
logic, rename iconOnly to isSolo, clean up comments, use Form
component in docs.
@johnleider
fix(Button): deduplicate attrs, add aria-busy, fix timer cleanup
c813385
@johnleider
fix(Button): expose id prop on ButtonContent and ButtonLoading
cc96545
@johnleider
fix(Button): align with Checkbox patterns, expose icon attrs in slotP…
9a48363 
…rops
@johnleider
fix(Splitter): add style to SlotProps attrs type
74ded4f
@johnleider
fix(Button): use registry for solo detection, improve test coverage
63e5c6c 
Replace DOM traversal in ButtonIcon with context-based detection via
root.single registry. Move aria-label warning to ButtonRoot. Add Icon,
HiddenInput, and solo detection tests. Coverage 76% → 96%.
@johnleider
fix(Button): default aria-label for solo icons, move onClick to slotP…
4622bb0 
…rops
@johnleider
fix(Button): add configurable grace prop, default to 0, collapse onClick
1bce10e
@johnleider
fix(Button): use ticket.unregister() for cleanup
0585580
@johnleider
chore: update Button maturity to preview, fix category to actions
93156b1
@johnleider
fix(Button): expose value on root context, HiddenInput inherits from …
f0b5c01 
…root
@johnleider
fix(Button): auto-render HiddenInput when name prop set, match Checkb…
d81dfea 
…ox pattern
@johnleider johnleider merged commit 718822f into master Mar 24, 2026
12 of 13 checks passed
@johnleider johnleider deleted the feat/button-component branch March 24, 2026 03:42
johnleider added a commit that referenced this pull request Mar 24, 2026
@johnleider
feat(Button): add new component (#166)
5f5ff6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@johnleider johnleider

Labels

C: Button

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

1 participant

@johnleider