feat(NumberField): add new component/composables#183
Merged
Conversation
|
commit: |
Root creates number field context via createNumberField, manages validation timing with validateOn, and provides context to children. Input renders a spinbutton with keyboard navigation, text parsing, and focus-dependent display formatting. Also extends createNumberField to forward error/errorMessages to createInput for manual validation state override.
Increment/Decrement buttons with spin-on-hold behavior (configurable spinDelay and spinRate). Scrub uses Pointer Lock API for click-and-drag value adjustment with configurable sensitivity.
Description and Error sub-components for help text and validation messages with ARIA connectivity. Barrel file exports all sub-components with JSDoc and compound NumberField object.
- Fix meta indentation to use 2-space indent per docs rules - Rewrite intros to be user-facing, not mentioning internal composables - Add missing aria-valuetext to ARIA attributes table - Fix PageUp/PageDown to reference leap instead of hardcoded "10 steps"
- Remove inline comments from Control (code is self-documenting) - Replace manual setTimeout/setInterval in Increment/Decrement with useTimer composable — auto-cleanup on scope dispose, cleaner API
…ean up Root - Description/Error: add id prop with useId() default, destructure from props - Same for Input.Description and Input.Error (consistency) - Control: remove inline comments - Root: destructure input from createNumberField inline
johnleider
force-pushed
the
feat/number-field-component
branch
from
4aeff03 to
6208158
Compare
johnleider
changed the title
johnleider
added a commit
that referenced
this pull request
Apr 11, 2026
Delete the standalone pkg-pr-new.yml workflow and add an equivalent pkg-pr-new job inside pr-checks.yml that downloads the dist artifact uploaded by the build job. Eliminates ~25s of duplicate install+build CI minutes per PR push. Drops the legacy 'labeled' pull_request trigger from the original workflow - empirically confirmed it was firing but not load-bearing. PR #183 (NumberField) alone republished 4 times on the same SHA because taxonomy labels (C: NumberField, E: createNumberField, E: createInput) were added one at a time, each triggering a fresh publish. Dropping 'labeled' stops that waste entirely. Uses the composite setup action (Stage 1c) for checkout/pnpm/node. actions/upload-artifact@v4 and actions/download-artifact@v4 with retention-days: 1 for minimal artifact lifetime. Stage 1d of v0 CI build time spec. Completes Stage 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="spinbutton",aria-valuenow/min/max/text)Intl.NumberFormat(currency, percent, units)Builds on #181 (createNumeric + createInput foundation).
Test plan