chore(ci): align PR validation Node with .nvmrc and enforce engines#432
Merged
Conversation
The local setup composite action used `node-version: lts/*` (Node 24), while the release build and `.nvmrc` use Node 26 and the README declares Node >= 26 — so a Node-26-only API could pass/ship yet fail PR CI on 24 (or the inverse), with nothing enforcing alignment. Point the setup action at `.nvmrc` (the same file release.yml uses) and add `engines.node: ">=26"` to machine-enforce the declared minimum. Closes #404 #404
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR validation ran on a different (lower) Node major than the release build and the declared minimum, with nothing enforcing alignment:
.github/actions/setup/action.ymlusednode-version: lts/*(Node 24 as of mid-2026) — and this composite action is used throughoutpr-checks.yml.release.ymlusesnode-version-file: .nvmrc(.nvmrc=26.0.0);README.mddeclares Node >= 26; noenginesfield enforced it.Risk: a Node-26-only API passes locally / ships via release but fails PR CI on 24 (or the inverse).
Fix:
node-version-file: .nvmrc, so PR CI resolves Node from the same file as the release build (cache: pnpmpreserved).engines.node: ">=26"topackage.jsonto machine-enforce the README/.nvmrc minimum.Scoped to PR validation per the issue —
metrics-regen.yml(separatesetup-nodeusage) left untouched. The--frozen-lockfilenote in the issue is a non-issue (pnpm auto-enables it whenCIis set), so not changed.package.jsonis valid JSON.Closes #404